Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kotlin example for filtering handler functions #27337

Merged
merged 1 commit into from Aug 30, 2021
Merged

Fix Kotlin example for filtering handler functions #27337

merged 1 commit into from Aug 30, 2021

Conversation

w3-3w
Copy link
Contributor

@w3-3w w3-3w commented Aug 30, 2021

The Kotlin code example at Filtering Handler Functions seems to be not equivalent to Java.

Suppose

The before filter that adds a custom request header is only applied to the two GET routes.
The after filter that logs the response is applied to all routes, including the nested ones.

is correct, POST("/person", handler::createPerson) and after() should not be inside nest, if my understanding to RouterFunction is correct.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 30, 2021
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 30, 2021
@sbrannen sbrannen changed the title Fix indent of Kotlin code example Fix Kotlin example for filtering handler functions Aug 30, 2021
@sbrannen sbrannen self-assigned this Aug 30, 2021
@sbrannen sbrannen added this to the 5.3.10 milestone Aug 30, 2021
@sbrannen sbrannen merged commit b120e0b into spring-projects:main Aug 30, 2021
@sbrannen
Copy link
Member

This has been merged into main.

Thanks for submitting your first PR to the Spring Framework! 👍

@w3-3w w3-3w deleted the fix-webmvc-functional-doc branch August 31, 2021 09:12
@jhoeller jhoeller added the for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x label Sep 2, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x Marks an issue as a candidate for backport to 5.2.x labels Sep 2, 2021
@spring-projects-issues spring-projects-issues mentioned this pull request Sep 2, 2021
Closed
jhoeller added a commit that referenced this pull request Sep 2, 2021
@jhoeller
Fix Kotlin example for filtering handler functions
eb349be 
Closes gh-27337
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@w3-3w @lxbzmy
Fix Kotlin example for filtering handler functions
d07b874 
Closes gh-spring-projects#27337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Milestone
5.3.10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@w3-3w @sbrannen @jhoeller @spring-projects-issues