New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UrlPathHelper#shouldRemoveSemicolonContent() #27303
Conversation
Hi @evpaassen, Can you please introduce a unit test that fails prior to the change and passes after the change? |
Hi @sbrannen, I added a test now. I'm not sure it really has added value, because nothing regarding the Please let me know if you're happy with it, or that I should make any changes. |
The checkReadOnly() method should only be called from methods that modify properties to prevent modification of read-only instances. Fixes spring-projects#27256
Yes, my intent was to make sure the problem is fixed and does not return (i.e., to serve as a regression test).
That looks good now. Thanks |
You're welcome. And thanks for reviewing and merging! |
The checkReadOnly() method should only be called from methods that modify properties to prevent modification of read-only instances. Fixes spring-projects#27256
Note that this was also backported to |
The checkReadOnly() method should only be called from methods that modify properties to prevent modification of read-only instances. Fixes spring-projects#27256
Fixes #27256
This PR fixes a bug that renders read-only
UrlPathHelper
s unusable, becauseshouldRemoveSemicolonContent()
throws an exception. For example, when usingUrlPathHelper#rawPathInstance
, which is read-only.The
checkReadOnly()
method should only be called from methods that modify properties to prevent modification of read-only instances.