Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference to Optional.isPresent() in ObjectUtils.isEmpty() #27223

Merged
merged 2 commits into from Jul 29, 2021
Merged

Fix reference to Optional.isPresent() in ObjectUtils.isEmpty() #27223

merged 2 commits into from Jul 29, 2021

Conversation

matvs
Copy link
Contributor

@matvs matvs commented Jul 29, 2021 •
edited by sbrannen

ObjectUtils.isEmpty() Javadoc mentions Optional.empty(), whereas empty() returns an empty Optional and Optional.isPresent() checks if Optional indeed is not empty.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 29, 2021
@sbrannen sbrannen self-assigned this Jul 29, 2021
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 29, 2021
@sbrannen sbrannen added this to the 5.3.10 milestone Jul 29, 2021
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Jul 29, 2021
@sbrannen sbrannen changed the title Fix reference to Optional.isEmpty() Method. Fix reference to Optional.isPresent() in ObjectUtils.isEmpty() Jul 29, 2021
@sbrannen sbrannen merged commit f1b35f1 into spring-projects:main Jul 29, 2021
@sbrannen
Copy link
Member

This has been merged into main.

Thanks for submitting your first PR to the Spring Framework!

sbrannen added a commit that referenced this pull request Jul 29, 2021
@sbrannen
Update copyright date
915f102 
See gh-27223
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@matvs @lxbzmy
Fix reference to Optional.isPresent() in ObjectUtils.isEmpty()
071683a 
Closes spring-projectsgh-27223
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@sbrannen @lxbzmy
Update copyright date
25a5bfa 
See spring-projectsgh-27223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Milestone
5.3.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matvs @sbrannen @spring-projects-issues