Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that ClientRequest.from(..) also copies body #27220

Closed
wants to merge 5 commits into from
Closed

Clarify that ClientRequest.from(..) also copies body #27220

wants to merge 5 commits into from

Conversation

AlexejTimonin
Copy link
Contributor

  • Add to javadoc that ClientRequest.from(..) will also copy body from the given request.
  • Add test to show that the body inserter will be copied over.

@pivotal-cla
Copy link

@AlexejTimonin Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 28, 2021
@pivotal-cla
Copy link

@AlexejTimonin Thank you for signing the Contributor License Agreement!

@rstoyanchev rstoyanchev self-assigned this Jul 29, 2021
@rstoyanchev rstoyanchev added type: documentation A documentation task type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 29, 2021
@rstoyanchev rstoyanchev added this to the 5.3.10 milestone Jul 29, 2021
sbrannen
sbrannen requested changes Jul 30, 2021
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested one small change to document that "attributes" are copied as well.

Please also update the copyright date in ClientRequest and DefaultClientRequestBuilderTests.

...ng-webflux/src/main/java/org/springframework/web/reactive/function/client/ClientRequest.java Outdated Show resolved Hide resolved
@AlexejTimonin
Copy link
Contributor Author

@sbrannen I could not see any tests for attributes in DefaultClientRequestBuilderTests so I updated the from() test to include attributes.

@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Jul 31, 2021
@rstoyanchev rstoyanchev removed the type: task A general task label Aug 4, 2021
rstoyanchev pushed a commit that referenced this pull request Aug 4, 2021
@AlexejTimonin @rstoyanchev
Improve Javadoc for ClientRequest#from
e290ae2 
See gh-27220
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 15, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@AlexejTimonin @lxbzmy
Improve Javadoc for ClientRequest#from
e6ce72a 
See spring-projectsgh-27220
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@rstoyanchev @lxbzmy
Polishing contribution
f29ca38 
Closes spring-projectsgh-27220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiangmao qiangmao qiangmao left review comments

@sbrannen sbrannen sbrannen approved these changes

Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: documentation A documentation task
Projects
None yet
Milestone
5.3.10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AlexejTimonin @pivotal-cla @sbrannen @qiangmao @rstoyanchev @spring-projects-issues