Avoid memory leak when PropertyComparator is reused #26869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing memoryleak, PropertyComparator was remembering the value it compared in the past.
|
@FlorianKirmaier Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
sbrannen
added
in: core
|
Thanks for submitting your first PR for the Spring Framework, @FlorianKirmaier! We would like to merge this into Can you please sign the Contributor License Agreement (see #26869 (comment)). |
sbrannen
added
the
status: waiting-for-feedback
|
@FlorianKirmaier Thank you for signing the Contributor License Agreement! |
|
Just signed the CLA. |
spring-projects-issues
added
status: feedback-provided
sbrannen
reviewed
Apr 30, 2021
| return this.beanWrapper.getPropertyValue(this.sortDefinition.getProperty()); | ||
| BeanWrapperImpl beanWrapper = new BeanWrapperImpl(false); | ||
| beanWrapper.setWrappedInstance(obj); | ||
| return beanWrapper.getPropertyValue(this.sortDefinition.getProperty()); | ||
| } |
There was a problem hiding this comment.
Please note that the formatting you introduced fails the build with the following.
> Task :spring-beans:checkstyleMain
[ant:checkstyle] [ERROR] /.../spring-beans/src/main/java/org/springframework/beans/support/PropertyComparator.java:116: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
[ant:checkstyle] [ERROR] /.../spring-beans/src/main/java/org/springframework/beans/support/PropertyComparator.java:117: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
[ant:checkstyle] [ERROR] /.../spring-beans/src/main/java/org/springframework/beans/support/PropertyComparator.java:118: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
Please make sure you run ./gradlew check before submitting a PR to catch such errors locally.
I'll fix the formatting before merging, so there's no need to update this PR.
|
This has been merged into Thanks |
Zoran0104
pushed a commit
to Zoran0104/spring-framework
that referenced
this pull request
Aug 20, 2021
This commit fixes a potential memory leak, since PropertyComparator previously kept an indirect reference to the value it last compared. Closes spring-projectsgh-26869
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
This commit fixes a potential memory leak, since PropertyComparator previously kept an indirect reference to the value it last compared. Closes spring-projectsgh-26869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing memoryleak, PropertyComparator was remembering the value it compared in the past.