Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spring-expression to be more easily repackaged for embedding in third-party JARs #26779

Merged
merged 1 commit into from Apr 9, 2021

Conversation

BFergerson
Copy link
Contributor

Compiled expressions don't work when you use https://imperceptiblethoughts.com/shadow/configuration/relocation/. This would allow the compiled expression to be relocated correctly.

plays nicer with package relocation
@pivotal-issuemaster
Copy link

@BFergerson Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@BFergerson Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 8, 2021
@sbrannen sbrannen changed the title Easier package relocation Allow spring-expression to be more easily repackaged for embedding in third-party JARs Apr 9, 2021
@sbrannen sbrannen self-assigned this Apr 9, 2021
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 9, 2021
@sbrannen sbrannen added this to the 5.3.6 milestone Apr 9, 2021
@sbrannen sbrannen merged commit 432c720 into spring-projects:master Apr 9, 2021
@sbrannen
Copy link
Member

sbrannen commented Apr 9, 2021

This has been merged into master.

Thanks

@BFergerson BFergerson deleted the patch-1 branch April 9, 2021 15:55
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this pull request Aug 20, 2021
This commit allows the spring-expression module to be more easily repackaged
for embedding in third-party JARs -- for example, via the Shadow Gradle plugin.

Closes spring-projectsgh-26779
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
This commit allows the spring-expression module to be more easily repackaged
for embedding in third-party JARs -- for example, via the Shadow Gradle plugin.

Closes spring-projectsgh-26779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants