Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dynamic changes in ThreadPoolTaskExecutor before setting local value #26700

Conversation

filiphr
Copy link
Contributor

@filiphr filiphr commented Mar 18, 2021

If the ThreadPoolTaskExecutor is dynamically changed with an invalid value
the state of the ThreadPoolTaskExecutor does no longer correctly represent
the state of the underlying ThreadPoolExecutor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 18, 2021
…value

If the ThreadPoolTaskExecutor is dynamically changed with an invalid value
the state of the ThreadPoolTaskExecutor does no longer correctly represent
the state of the underlying ThreadPoolExecutor
@filiphr filiphr force-pushed the dynamic-threadpool-task-executor-changes branch from f4f15f6 to 3a51869 Compare March 18, 2021 15:31
@filiphr
Copy link
Contributor Author

filiphr commented Jun 23, 2021

Hey team, I wanted to check if you have had the time to look into the PR. Is this something interesting for you? Is there something more that I should do about this?

@jhoeller jhoeller self-assigned this Jun 23, 2021
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 23, 2021
@jhoeller jhoeller added this to the 5.3.9 milestone Jun 23, 2021
@jhoeller
Copy link
Contributor

Thanks for raising attention here, this unfortunately remained unnoticed initially.
Looks good to from a quick glance, I'll roll it into 5.3.9.

@jhoeller jhoeller merged commit 5311742 into spring-projects:main Jul 9, 2021
Zoran0104 pushed a commit to Zoran0104/spring-framework that referenced this pull request Aug 20, 2021
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants