Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allowedOriginPatterns in SockJS config #26108

Closed
wants to merge 2 commits into from
Closed

Support allowedOriginPatterns in SockJS config #26108

wants to merge 2 commits into from

Conversation

BenjaminFaal
Copy link

Now you can also add allowed origin patterns to the websocket CORS config.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 17, 2020
@rstoyanchev rstoyanchev self-assigned this Nov 18, 2020
@rstoyanchev rstoyanchev added this to the 5.3.2 milestone Nov 18, 2020
@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 18, 2020
@rstoyanchev rstoyanchev linked an issue Nov 18, 2020 that may be closed by this pull request
Not possible to use allowedOrigins "*" in StompEndpointRegistry after upgrade to Spring Boot 2.4.0 #26111
Closed
@rstoyanchev rstoyanchev mentioned this pull request Nov 18, 2020
Closed
@rstoyanchev rstoyanchev added type: regression A bug that is also a regression and removed type: enhancement A general enhancement labels Nov 18, 2020
@rstoyanchev rstoyanchev changed the title Add allowed origin patterns to websocket Support allowedOriginPatterns in SockJS config Nov 18, 2020
@BenjaminFaal
Copy link
Author

@rstoyanchev i added 6d628a1 now i think its complete.

rstoyanchev pushed a commit that referenced this pull request Nov 18, 2020
@rstoyanchev
Add allowedOriginPatterns to SockJS config
ae75db2 
See gh-26108
rstoyanchev added a commit that referenced this pull request Nov 18, 2020
@rstoyanchev
Polishing contribution
9beca06 
See gh-26108
rstoyanchev added a commit that referenced this pull request Nov 18, 2020
@rstoyanchev
Apply allowedOriginPatterns in SockJsService
8130bf5 
See gh-26108
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 10, 2020
Merged
@rstoyanchev rstoyanchev mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rstoyanchev rstoyanchev

Labels
in: messaging Issues in messaging modules (jms, messaging) type: regression A bug that is also a regression
Projects
None yet
Milestone
5.3.2
Development

Successfully merging this pull request may close these issues.

Not possible to use allowedOrigins "*" in StompEndpointRegistry after upgrade to Spring Boot 2.4.0
3 participants
@BenjaminFaal @rstoyanchev @spring-projects-issues