Improve AdvisedSupport.getAdvisors() #26017
Merged
+24
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
stsypanov
force-pushed
the
advised-sup
branch
from
96f446b to
1db76b9
Compare
jhoeller
added a commit
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios
AdvisedSupport.updateAdvisorArray()takes about 30% ofAdvisedSupport.addAdvisor()(see attachment) and is pointless in fact, as the only place where we useadvisorArrayisAdvisedSupport.getAdvisors(). So we can rewrite the code to retrieve the array from theadvisorslist only when it is necessary instead of rewriting it on each addition or removal of advice.This allows to simplify code and remove
advisorArray. In order to reduce allocation rate I've also introducedAdvisedSupport.getAdvisorCount().