Extending the incoming Stomp sessionId as an attribute in TcpClient #25924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essageHandler down to the TcpClient. In this way, we can customize the bootstrap of the TcpClient, allowing a more sophisticated selection of the remoteAddress, since now we can gain access to the attributes populated by ReactorNettyTcpClient inside the TcpClient#doOnConnect() callback. The final idea is to be able to balance the load of the Stomp cluster, by grouping all sessions from the same user in the same Stomp Broker Relay server.
|
@rupebac Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@rupebac Thank you for signing the Contributor License Agreement! |
|
Closing as per #25889 (comment). Thanks for the suggestion. |
rstoyanchev
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final idea is to be able to balance the load of the Stomp cluster, by grouping all sessions from the same user in the same Stomp Broker Relay server.
In order to achieve this, the very bare minimum is to gain access to the session Id at the TcpClient#doOnConnect callbacks, in order to customize from there the specific instance of the TcpClient#remoteAddress supplier.
Of course, passing on the whole StompHeaderAccessor from StompBrokerRelayMessageHandler#handleMessageInternal to ReactorNettyTcpClient may be better for my case, but it may perhaps make the average usages a bit more complicated.
I am very much open for suggestions or discussions on this matter.
This solves #25889 .