Improve Random seed in SocketUtils #25321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue where System.currentTimeMillis() was a bad seed when a few tests were running in parallel. I want to override the random to use nanoTime().
|
@jryan128 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: core
sbrannen
changed the title
sbrannen
removed
for: team-attention
status: waiting-for-triage
NielsUll
reviewed
Jul 1, 2020
| * Default uses {@code System.currentTimeMillis()} instead of {@code Random}'s default. | ||
| */ | ||
| public static void setRandom(Random random) { | ||
| SocketUtils.random = random; |
There was a problem hiding this comment.
Add null validation:
Assert.notNull(random, "'random' must not be null");
|
While I understand your problem, having mutable static state which affect behaviour of static methods is very dangerous from an architectural point of view. Any code could call |
|
Instead of making the private static final Random random = new Random(System.nanoTime());Would that suit your needs? |
sbrannen
added
the
status: waiting-for-feedback
|
Yes
…On Thu, Jul 2, 2020, 08:17 Sam Brannen ***@***.***> wrote:
Instead of making the Random instance configurable, we are rather
considering instantiating it as follows.
private static final Random random = new Random(System.nanoTime());
Would that suit your needs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE4JYX7UMTTIHSCYCTXTJ3RZR3EVANCNFSM4OJR4VIQ>
.
|
spring-projects-issues
added
status: feedback-provided
|
Thanks for the PR. As mentioned above, I implemented it slightly differently in 35582de for |
sbrannen
changed the title
|
Thank you so much!!
…On Fri, Jul 3, 2020 at 6:20 AM Sam Brannen ***@***.***> wrote:
Thanks for the PR.
As mentioned above, I implemented it slightly differently in 35582de
<35582de>
for 5.2.8 and 5.3 M2.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25321 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE4JYSZ6LKDBBWKMVVD2GLRZWWFBANCNFSM4OJR4VIQ>
.
|
FelixFly
pushed a commit
to FelixFly/spring-framework
that referenced
this pull request
Aug 16, 2020
Prior to this commit, SocketUtils used System.currentTimeMillis() for the seed for the java.util.Random instance used internally. The use of the milliseconds value returned by currentTimeMillis() can lead to collisions for randomly selected free ports for tests executing in parallel on the same computer. This commit therefore switches to System.nanoTime() for the Random seed used in SocketUtils in an attempt to avoid such collisions for tests executing in parallel in different JVMs on the same computer. Closes spring-projectsgh-25321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue where
System.currentTimeMillis()was a bad seed when a few tests were running in parallel. I want to be able to override the random to usenanoTime().