Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve Http Response Info When MessageConverter Not Found Case #24994

Closed
wants to merge 1 commit into from
Closed

Preserve Http Response Info When MessageConverter Not Found Case #24994

wants to merge 1 commit into from

Conversation

devinabyss
Copy link

And Introduce Detail Purpose When Response Could Not Extract

#24964

@devinabyss
Preserve Http Response Info When MessageConverter Not Found Case
2306673 
And Introduce Detail Purpose When Response Could Not Extract
@devinabyss devinabyss changed the title Preserve Http Response Info When MessageConverter Not Found Case #24964 Preserve Http Response Info When MessageConverter Not Found Case Apr 29, 2020
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 29, 2020
rstoyanchev
rstoyanchev requested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinabyss I'm not sure we need to expand with 3 new exceptions. Just one RestClientResponseException to replace the "no suitable HttpMessageConverter" case.

@rstoyanchev rstoyanchev added the status: waiting-for-feedback We need additional information before we can continue label Apr 30, 2020
@rstoyanchev rstoyanchev self-assigned this Apr 30, 2020
@devinabyss
Copy link
Author

devinabyss commented Apr 30, 2020 •
edited

@devinabyss I'm not sure we need to expand with 3 new exceptions. Just one RestClientResponseException to replace the "no suitable HttpMessageConverter" case.

sorry about no more discuss about that on issue thread.

RestClientResponseException.FailedToReadResponseBody arises when converter body extracting failed. you first mentioned case on issue thread.

After modifying the RestClientResponseException.MessageConverterNotFound, I thought that preserving the rest of the information (headers, specific 2xx status) is intentionally right, although in the sense of preserving the information of response, of course the body is impossible.

Can I just keep RestClientResponseException.MessageConverterNotFound?

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 30, 2020
@rstoyanchev
Copy link
Contributor

Can I just keep RestClientResponseException.MessageConverterNotFound?

I don't see the value. It's not something that can be handled and it's in the root cause.

@rstoyanchev
Copy link
Contributor

I've resolved this by adding an UnknownContentTypeException sub-class. Thanks for the PR in any case.

@rstoyanchev rstoyanchev closed this May 4, 2020
@rstoyanchev rstoyanchev added status: superseded An issue that has been superseded by another and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged or decided on labels May 4, 2020
@devinabyss
Copy link
Author

thanks.
sorry for my reaction was late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstoyanchev rstoyanchev rstoyanchev requested changes

Assignees

@rstoyanchev rstoyanchev

Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devinabyss @rstoyanchev @spring-projects-issues