Skip to content

Declare proxyBeanMethods=false in JmsBootstrapConfiguration #24752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Declare proxyBeanMethods=false in JmsBootstrapConfiguration #24752

merged 1 commit into from
Mar 23, 2020
+2 −2

Conversation

chenqimiao
Copy link
Contributor

@chenqimiao chenqimiao commented Mar 21, 2020 •
edited
Loading

@Bean annotated methods are not explicitly called by other methods in JmsBootstrapConfiguration, so I think we can set proxyBeansMethod attribute of @Configuration to false to avoid CGLIB subclass processing.
This can improve performance, although not a lot.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 21, 2020
@chenqimiao chenqimiao changed the title Set proxyBeansMethod to false when no method is called Set proxyBeansMethod to false when no Bean method is explicitly called Mar 21, 2020
@jhoeller jhoeller self-assigned this Mar 21, 2020
@jhoeller jhoeller added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 21, 2020
@jhoeller jhoeller added this to the 5.2.5 milestone Mar 21, 2020
@jhoeller jhoeller changed the title Set proxyBeansMethod to false when no Bean method is explicitly called Declare proxyBeanMethods=false in JmsBootstrapConfiguration Mar 21, 2020
@jhoeller jhoeller merged commit 0463d7f into spring-projects:master Mar 23, 2020
@chenqimiao chenqimiao deleted the proxy-beans-method branch March 25, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenqimiao @jhoeller @spring-projects-issues