ExecutorConfigurationSupport to allow millisecond precision for await termination period #24496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "ExecutorConfigurationSupport#setAwaitTerminationDuration" which takes "Duration" to await internal executor termination.
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
requested changes
Feb 11, 2020
...xt/src/main/java/org/springframework/scheduling/concurrent/ExecutorConfigurationSupport.java
Show resolved
Hide resolved
...xt/src/main/java/org/springframework/scheduling/concurrent/ExecutorConfigurationSupport.java
Show resolved
Hide resolved
...xt/src/main/java/org/springframework/scheduling/concurrent/ExecutorConfigurationSupport.java
Show resolved
Hide resolved
rstoyanchev
added
in: core
jhoeller
removed
the
status: waiting-for-triage
|
I've turned that into |
rstoyanchev
changed the title
|
cool, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
ExecutorConfigurationSupport(ThreadPoolTask[Executor|Scheduler]) only takes seconds for await termination.I'm writing a graceful shutdown logic for k8s environment and awaiting by second is a bit large granularity to control the shutdown/await. Graceful shutdown get triggered by liveness probe and the frequency for liveness probe is not so long.
This PR changes the minimum unit to milliseconds and adds a method to take
Durationto specify the await termination.