Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use String.isEmpty() instead of String.equals("") #24052

Merged
merged 1 commit into from Nov 21, 2019
Merged

Use String.isEmpty() instead of String.equals("") #24052

merged 1 commit into from Nov 21, 2019

Conversation

stsypanov
Copy link
Contributor

There are certains cases when we are sure that String is not null, so instead of using equals("") we can call String.isEmpty() making core more readable.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 21, 2019
@jhoeller jhoeller merged commit 1f3b595 into spring-projects:master Nov 21, 2019
@jhoeller jhoeller self-assigned this Nov 21, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 21, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 21, 2019
@stsypanov stsypanov deleted the isEmpty branch November 22, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stsypanov @jhoeller @spring-projects-issues