ApplicationListenerMethodAdapter: gracefully handle beans which are actually NullBean #23784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually NullBean Currently, if you have an optional event listener (via a @bean method returning `null`) this causes the event multicaster to explode violently. Now, we just safely skip it.
spring-projects-issues
added
the
status: waiting-for-triage
|
Any comments on this fix? We are eagerly anticipating having our code work as expected, and it seems unlikely to cause a regression. |
jhoeller
added
in: core
jhoeller
added a commit
that referenced
this pull request
Nov 11, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have an optional event listener (via a @bean method returning
null)this causes the event multicaster to explode violently. Now, we just safely skip it.