Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit cancellation of transactional Monos in TransactionOperator #23562

Merged
merged 1 commit into from Sep 20, 2019
Merged

Omit cancellation of transactional Monos in TransactionOperator #23562

merged 1 commit into from Sep 20, 2019

Commits on Sep 2, 2019

  1. Omit cancellation of transactional Monos in TransactionOperator 

    TransactionOperator.as(Mono) now no longer short-cuts via a Flux.next() but provides an implementation via Mono.usingWhen(…).
The short-cut previously issued a cancellation signal to the transactional Mono causing the transaction cleanup to happen without a handle for synchronization.

Using Mono.usingWhen(…) initiates transaction cleanup when the Mono completes eliminating the need for cancellation of the transactional Publisher.

This change does not fully fix spring-projectsgh-23304 but it softens its impact because TransactionalOperator.transactional(Mono) avoids cancellation.
    @mp911de
    mp911de committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    edfe30b View commit details
    Browse the repository at this point in the history