Preserve the originalMessage when creating an ErrorMessage in MessageBuilder #23417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew ErrorMessage using MessageBuilder.fromMessage method.
spring-projects-issues
added
the
status: waiting-for-triage
|
Also if the aforementioned is the case - it might be worthwhile to apply the same flow for org.springframework.integration.support.MessageBuilder#build implementation from integration-core package |
rstoyanchev
reviewed
Nov 8, 2019
spring-messaging/src/main/java/org/springframework/messaging/support/MessageBuilder.java
Show resolved
Hide resolved
rstoyanchev
added
in: messaging
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Nov 8, 2019
|
This has been merged with some minor polishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was creating a small POC using spring integration and for some cases I noticed that Gateways that use messagingTemplate underneath do not preserve the original message when sending a related ErrorMessage to the error channel.
I didn't find any better place to address that.
In my opinion original message worth preserving in any case. However there is another possibility to pass the MessageBuilder.originalMessage link without unwrapping it