Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queryParam method to MockHttpServletRequestBuilder #23414

Closed
wants to merge 5 commits into from
Closed

Add queryParam method to MockHttpServletRequestBuilder #23414

wants to merge 5 commits into from

Conversation

jo2
Copy link
Contributor

@jo2 jo2 commented Aug 3, 2019 •
edited

fix #23296

add query params to query string in builder method in MockHttpServletRequestBuilder

add tests

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 3, 2019
@rstoyanchev
Copy link
Contributor

Thanks for the PR but it does not match what was agreed upon in the related ticket:

we can add a queryParam method as an extra convenience

Also we expect commits to be organized into logical commits, and squashed if necessary. The idea is that we don't want extra commits that reflect various drafts.

@rstoyanchev rstoyanchev added status: waiting-for-feedback We need additional information before we can continue in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 8, 2019
@rstoyanchev rstoyanchev changed the title Query param fix Add queryParam method to MockHttpServletRequestBuilder Nov 8, 2019
@jo2 jo2 closed this Nov 12, 2019
@jo2 jo2 deleted the query-param-fix branch November 12, 2019 13:09
@jo2 jo2 restored the query-param-fix branch November 12, 2019 13:10
@jo2
Copy link
Contributor Author

jo2 commented Nov 12, 2019

new pr #23980

@rstoyanchev rstoyanchev added status: superseded An issue that has been superseded by another and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add queryParam method to MockHttpServletRequestBuilder
4 participants
@jo2 @rstoyanchev @spring-projects-issues @maximAtanasov