Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending headers with the disconnect frame #22715

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -360,9 +360,17 @@ private void unsubscribe(String id, @Nullable StompHeaders headers) {

@Override
public void disconnect() {
disconnect(null);
}

@Override
public void disconnect(@Nullable StompHeaders headers) {
this.closing = true;
try {
StompHeaderAccessor accessor = createHeaderAccessor(StompCommand.DISCONNECT);
if (headers != null) {
accessor.addNativeHeaders(headers);
}
Message<byte[]> message = createMessage(accessor, EMPTY_PAYLOAD);
execute(message);
}
Expand Down
Expand Up @@ -116,6 +116,12 @@ public interface StompSession {
*/
void disconnect();

/**
* Disconnect the session by sending a DISCONNECT frame.
* @param headers the headers for the disconnect message frame
*/
void disconnect(StompHeaders headers);


/**
* A handle to use to track receipts.
Expand Down
Expand Up @@ -636,4 +636,25 @@ public void disconnect() {
verifyNoMoreInteractions(this.sessionHandler);
}

@Test
public void disconnectWithHeaders() {
this.session.afterConnected(this.connection);
assertTrue(this.session.isConnected());

StompHeaders headers = new StompHeaders();
headers.add("foo", "bar");

this.session.disconnect(headers);

Message<byte[]> message = this.messageCaptor.getValue();
StompHeaderAccessor accessor = MessageHeaderAccessor.getAccessor(message, StompHeaderAccessor.class);
headers = StompHeaders.readOnlyStompHeaders(accessor.getNativeHeaders());
assertEquals(headers.toString(), 1, headers.size());
assertEquals(headers.get("foo").size(), 1);
assertEquals(headers.get("foo").get(0), "bar");

assertFalse(this.session.isConnected());
verifyNoMoreInteractions(this.sessionHandler);
}

}