Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behaviour of AnnotationBeanNameGenerator with acronyms #2030

Closed
wants to merge 1 commit into from

Conversation

matips
Copy link
Contributor

@matips matips commented Nov 28, 2018

Name transformation is delegated java.beans.Introspector#decapitalize. It says "but in the (unusual) special case when there is more than one character and both the first and second characters are upper case, we leave it alone.". It should be reflected in documentation

Name transformation is delegated java.beans.Introspector#decapitalize. It says "but in the (unusual) special  case when there is more than one character and both the first and second characters are upper case, we leave it alone.". It should be reflected in documentation
@pivotal-issuemaster
Copy link

@matips Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 11, 2021
@pivotal-cla
Copy link

@matips Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@snicoll snicoll changed the title Update AnnotationBeanNameGenerator.java Clarify behaviour of AnnotationBeanNameGenerator with acronmys Nov 24, 2021
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 24, 2021
@snicoll snicoll self-assigned this Nov 24, 2021
@snicoll snicoll added this to the 5.3.14 milestone Nov 24, 2021
@snicoll
Copy link
Member

snicoll commented Nov 24, 2021

@pivotal-issuemaster this is an obvious fix

@snicoll snicoll changed the title Clarify behaviour of AnnotationBeanNameGenerator with acronmys Clarify behaviour of AnnotationBeanNameGenerator with acronyms Nov 24, 2021
snicoll pushed a commit that referenced this pull request Nov 24, 2021
Name transformation is delegated to Introspector#decapitalize, which
states "but in the (unusual) special case when there is more than one
character and both the first and second characters are upper case, we
leave it alone.". This commit clarifies this behavior.

See gh-2030
@snicoll snicoll closed this in 82d6e07 Nov 24, 2021
@snicoll
Copy link
Member

snicoll commented Nov 24, 2021

@matips thank you for making your first contribution to Spring Framework.

bclozel added a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants