SPR-7582 - Rebuild Advisor chain when interceptor list is updated in ProxyFactoryBean #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getObject() on ProxyFactoryBean is called it might not be fully initialized yet, leading to an exception. This is fine, but the empty Advisor chain is never rebuilt, not even after initialization has finished. This leads to 'no-op' proxies which don't do anything. Issue: SPR-7582
snicoll
changed the title
|
+1 |
|
I faced the same problem while using constructor injection of proxies in proxies. I sorted it out using targetName in ProxyFactoryBean instead of target referencing the bean, because changing bean order definition is not always possible. This fix can be helpful in many situations |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
the
in: core
jhoeller
added
type: bug
|
On review, we're going with a simpler change (just covering late initialization, not re-initialization) for the original report #12238. Thanks for the pull request, in any case, and sorry that it took so long... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getObject() on ProxyFactoryBean is called it might not be
fully initialized yet, leading to an exception. This is fine, but
the empty Advisor chain is never rebuilt, not even after initialization
has finished. This leads to 'no-op' proxies which don't do anything.
Issue: SPR-7582