Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non Singletons being included even with includeNonSingletons #28615

Closed
fsgonz opened this issue Jun 13, 2022 · 3 comments
Closed

Non Singletons being included even with includeNonSingletons #28615

fsgonz opened this issue Jun 13, 2022 · 3 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: bug A general bug

Comments

@fsgonz
Copy link
Contributor

fsgonz commented Jun 13, 2022

Hi!

I have seen that this verification was removed.

I think that will result in beans being created even when you indicate that nonSingletons should not be included.

Can you verify if there is a reason for not adding this change?

This seems to be a bug introduced here

Our app is failing because of this. I'll try to add a test but can you take a look at it meanwhile?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 13, 2022
@jhoeller jhoeller self-assigned this Jun 13, 2022
@fsgonz
Copy link
Contributor Author

fsgonz commented Jun 13, 2022

I've opened this PR. #28616

@fsgonz fsgonz changed the title Singletons being included even with includeNonSingletons Non Singletons being included even with includeNonSingletons Jun 13, 2022
@fsgonz
Copy link
Contributor Author

fsgonz commented Jun 13, 2022

This issue and the comment in particular may be related to this.

@sbrannen sbrannen mentioned this issue Jun 14, 2022
Closed
@sbrannen sbrannen assigned sbrannen and unassigned jhoeller Jun 14, 2022
@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 14, 2022
@sbrannen sbrannen added this to the 5.3.21 milestone Jun 14, 2022
@sbrannen
Copy link
Member

Superseded by:

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
@sbrannen sbrannen removed this from the 5.3.21 milestone Jun 14, 2022
@sbrannen sbrannen added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbrannen @jhoeller @spring-projects-issues @fsgonz