Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid eager instantiation of non-singleton FactoryBean in getBeanNamesForType #28616

Closed
wants to merge 1 commit into from
Closed

Avoid eager instantiation of non-singleton FactoryBean in getBeanNamesForType #28616

wants to merge 1 commit into from

Conversation

fsgonz
Copy link
Contributor

@fsgonz fsgonz commented Jun 13, 2022 •
edited by sbrannen

Fix for #28615

@fsgonz fsgonz mentioned this pull request Jun 13, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 13, 2022
@sbrannen sbrannen self-assigned this Jun 14, 2022
@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 14, 2022
@fsgonz fsgonz changed the title Fix: extra singleton beans created Fix: extra non singleton beans created Jun 14, 2022
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 14, 2022
@sbrannen sbrannen changed the title Fix: extra non singleton beans created Avoid eager instantiation of non-singleton FactoryBean in getBeanNamesForType Jun 14, 2022
@sbrannen sbrannen added this to the 5.3.21 milestone Jun 14, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Jun 14, 2022
@sbrannen
Polish contribution
eeac150 
See spring-projectsgh-28616
@sbrannen sbrannen closed this in 0ce9516 Jun 14, 2022
@sbrannen
Copy link
Member

This has been merged into 5.3.x and main in 0ce9516 and revised (with a test) in eeac150.

Thanks for making your first contribution to the Spring Framework! 👍

@sbrannen sbrannen mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
5.3.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fsgonz @sbrannen @spring-projects-issues