Skip to content

Commit

Permalink
Improve getMultipartContentType in mock request.
Browse files Browse the repository at this point in the history
  • Loading branch information
Frederik Boster authored and rstoyanchev committed Nov 29, 2019
1 parent 47779df commit a15a726
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 2 deletions.
Expand Up @@ -16,13 +16,16 @@

package org.springframework.mock.web;

import java.io.IOException;
import java.util.Collections;
import java.util.Enumeration;
import java.util.Iterator;
import java.util.List;
import java.util.Map;

import javax.servlet.ServletContext;
import javax.servlet.ServletException;
import javax.servlet.http.Part;

import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpMethod;
Expand Down Expand Up @@ -121,9 +124,17 @@ public String getMultipartContentType(String paramOrFileName) {
if (file != null) {
return file.getContentType();
}
else {
return null;

try {
Part part = getPart(paramOrFileName);
if (part != null) {
return part.getContentType();
}
} catch (ServletException | IOException e) {
throw new IllegalStateException("Cannot extract content type from multipart request.", e);
}

return null;
}

@Override
Expand Down
Expand Up @@ -27,6 +27,8 @@

import org.junit.jupiter.api.Test;

import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType;
import org.springframework.util.FileCopyUtils;
import org.springframework.util.ObjectUtils;
import org.springframework.web.multipart.MultipartFile;
Expand Down Expand Up @@ -61,6 +63,24 @@ void mockMultipartHttpServletRequestWithInputStream() throws IOException {
doTestMultipartHttpServletRequest(request);
}

@Test
void mockMultiPartHttpServletRequestWithMixedData() {
MockMultipartHttpServletRequest request = new MockMultipartHttpServletRequest();
request.addFile(new MockMultipartFile("file", "myOrigFilename", MediaType.TEXT_PLAIN_VALUE, "myContent2".getBytes()));

MockPart metadataPart = new MockPart("metadata", "{\"foo\": \"bar\"}".getBytes());
metadataPart.getHeaders().setContentType(MediaType.APPLICATION_JSON);
request.addPart(metadataPart);

HttpHeaders fileHttpHeaders = request.getMultipartHeaders("file");
assertThat(fileHttpHeaders).isNotNull();
assertThat(fileHttpHeaders.getContentType()).isEqualTo(MediaType.TEXT_PLAIN);

HttpHeaders dataHttpHeaders = request.getMultipartHeaders("metadata");
assertThat(dataHttpHeaders).isNotNull();
assertThat(dataHttpHeaders.getContentType()).isEqualTo(MediaType.APPLICATION_JSON);
}

private void doTestMultipartHttpServletRequest(MultipartHttpServletRequest request) throws IOException {
Set<String> fileNames = new HashSet<>();
Iterator<String> fileIter = request.getFileNames();
Expand Down

0 comments on commit a15a726

Please sign in to comment.