Skip to content

Commit

Permalink
Polish StartupStep "tags" method
Browse files Browse the repository at this point in the history
Renaming the `tags` method to `getTags` for overall consistency, and
fixing the Javadoc to mention that this returns an immutable collection.

Closes gh-25678
  • Loading branch information
bclozel committed Sep 2, 2020
1 parent f55b48f commit 88249b2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Expand Up @@ -57,7 +57,7 @@ public Long getParentId() {
}

@Override
public Tags tags() {
public Tags getTags() {
return this.TAGS;
}

Expand Down
Expand Up @@ -76,7 +76,7 @@ public interface StartupStep {
/**
* Return the {@link Tag} collection for this step.
*/
Tags tags();
Tags getTags();

/**
* Record the state of the step and possibly other metrics like execution time.
Expand All @@ -86,7 +86,7 @@ public interface StartupStep {


/**
* Mutable collection of {@link Tag}.
* Immutable collection of {@link Tag}.
*/
interface Tags extends Iterable<Tag> {
}
Expand Down
Expand Up @@ -77,7 +77,7 @@ public StartupStep tag(String key, Supplier<String> value) {
}

@Override
public Tags tags() {
public Tags getTags() {
return this.tags;
}

Expand Down

0 comments on commit 88249b2

Please sign in to comment.