Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It happens very often that MockMvc is used in heavyweight integration tests. It's no use to waste time to check if another condition has been fixed or not. Soft assertion could help a lot to check all conditions at once even if one of them fail.
- Loading branch information
Showing
3 changed files
with
92 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
spring-test/src/test/java/org/springframework/test/web/servlet/ResultMatcherTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package org.springframework.test.web.servlet; | ||
|
||
import org.jetbrains.annotations.NotNull; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThatExceptionOfType; | ||
import static org.assertj.core.api.Assertions.assertThatNoException; | ||
|
||
class ResultMatcherTest { | ||
|
||
@Test | ||
void whenProvidedMatcherPassesThenSoftAssertionsAlsoPasses() { | ||
ResultMatcher resultMatcher = ResultMatcher.matchAllSoftly(this::doNothing); | ||
StubMvcResult stubMvcResult = new StubMvcResult(null, null, null, null, null, null, null); | ||
|
||
assertThatNoException().isThrownBy(() -> resultMatcher.match(stubMvcResult)); | ||
} | ||
|
||
@Test | ||
void whenOneOfMatcherFailsThenSoftAssertionFailsWithTheVerySameMessage() { | ||
String failMessage = "fail message"; | ||
StubMvcResult stubMvcResult = new StubMvcResult(null, null, null, null, null, null, null); | ||
ResultMatcher resultMatcher = ResultMatcher.matchAllSoftly(failMatcher(failMessage)); | ||
|
||
assertThatExceptionOfType(AssertionError.class) | ||
.isThrownBy(() -> resultMatcher.match(stubMvcResult)) | ||
.withMessage(failMessage); | ||
} | ||
|
||
@Test | ||
void whenMultipleMatchersFailsThenSoftAssertionFailsWithOneErrorWithMessageContainingAllErrorMessagesWithTheSameOrder() { | ||
String firstFail = "firstFail"; | ||
String secondFail = "secondFail"; | ||
StubMvcResult stubMvcResult = new StubMvcResult(null, null, null, null, null, null, null); | ||
ResultMatcher resultMatcher = ResultMatcher.matchAllSoftly(failMatcher(firstFail), failMatcher(secondFail)); | ||
|
||
assertThatExceptionOfType(AssertionError.class) | ||
.isThrownBy(() -> resultMatcher.match(stubMvcResult)) | ||
.withMessage(firstFail + "\n" + secondFail); | ||
} | ||
|
||
@NotNull | ||
private ResultMatcher failMatcher(String failMessage) { | ||
return result -> { | ||
throw new AssertionError(failMessage); | ||
}; | ||
} | ||
|
||
void doNothing(MvcResult mvcResult) {} | ||
} |