Skip to content

Commit

Permalink
Align forRawClassAssignableFromTypeVariable with 5.1 assertion style
Browse files Browse the repository at this point in the history
  • Loading branch information
jhoeller committed Jul 20, 2019
1 parent e5bef10 commit 209c850
Showing 1 changed file with 15 additions and 19 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2018 the original author or authors.
* Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -135,41 +135,41 @@ public void forRawClassWithNull() throws Exception {
assertTrue(type.isAssignableFrom(String.class));
}

@Test
public void forRawClassAssignableFromTypeVariable() { // gh-23321
@Test // gh-23321
public void forRawClassAssignableFromTypeVariable() throws Exception {
ResolvableType typeVariable = ResolvableType.forClass(ExtendsList.class).as(List.class).getGeneric();
ResolvableType raw = ResolvableType.forRawClass(CharSequence.class);
assertThat(raw.resolve()).isEqualTo(CharSequence.class);
assertThat(typeVariable.resolve()).isEqualTo(CharSequence.class);
assertThat(raw.resolve().isAssignableFrom(typeVariable.resolve())).isTrue();
assertThat(typeVariable.resolve().isAssignableFrom(raw.resolve())).isTrue();
assertThat(raw.isAssignableFrom(typeVariable)).isTrue();
assertThat(typeVariable.isAssignableFrom(raw)).isTrue();
assertThat(raw.resolve(), equalTo(CharSequence.class));
assertThat(typeVariable.resolve(), equalTo(CharSequence.class));
assertTrue(raw.resolve().isAssignableFrom(typeVariable.resolve()));
assertTrue(typeVariable.resolve().isAssignableFrom(raw.resolve()));
assertTrue(raw.isAssignableFrom(typeVariable));
assertTrue(typeVariable.isAssignableFrom(raw));
}

@Test
public void forInstanceMustNotBeNull() {
public void forInstanceMustNotBeNull() throws Exception {
this.thrown.expect(IllegalArgumentException.class);
this.thrown.expectMessage("Instance must not be null");
ResolvableType.forInstance(null);
}

@Test
public void forInstanceNoProvider() {
public void forInstanceNoProvider() throws Exception {
ResolvableType type = ResolvableType.forInstance(new Object());
assertThat(type.getType(), equalTo(Object.class));
assertThat(type.resolve(), equalTo(Object.class));
}

@Test
public void forInstanceProvider() {
public void forInstanceProvider() throws Exception {
ResolvableType type = ResolvableType.forInstance(new MyGenericInterfaceType<>(String.class));
assertThat(type.getRawClass(), equalTo(MyGenericInterfaceType.class));
assertThat(type.getGeneric().resolve(), equalTo(String.class));
}

@Test
public void forInstanceProviderNull() {
public void forInstanceProviderNull() throws Exception {
ResolvableType type = ResolvableType.forInstance(new MyGenericInterfaceType<String>(null));
assertThat(type.getType(), equalTo(MyGenericInterfaceType.class));
assertThat(type.resolve(), equalTo(MyGenericInterfaceType.class));
Expand Down Expand Up @@ -443,12 +443,8 @@ public void getInterfaces() throws Exception {
interfaces.add(interfaceType.toString());
}
assertThat(interfaces.toString(), equalTo(
"["
+ "java.io.Serializable, "
+ "java.lang.Cloneable, "
+ "java.util.List<java.lang.CharSequence>, "
+ "java.util.RandomAccess"
+ "]"));
"[java.io.Serializable, java.lang.Cloneable, " +
"java.util.List<java.lang.CharSequence>, java.util.RandomAccess]"));
}

@Test
Expand Down

0 comments on commit 209c850

Please sign in to comment.