DATAREDIS-1060 - Redis password should not automatically be applied to Sentinel. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove data node password reuse for sentinel as we favor explicit configuration over implicit. Use RedisURI builder and not sentinel URI builder to configure the SentinelURI correctly. Associate masterId with outermost RedisURI.
mp911de
pushed a commit
that referenced
this pull request
Nov 12, 2019
…o Sentinel. We now expose two separate properties in RedisSentinelConfiguration to configure the data password individually from the sentinel password. Original pull request: #495.
mp911de
added a commit
that referenced
this pull request
Nov 12, 2019
Remove data node password reuse for sentinel as we favor explicit configuration over implicit. Use RedisURI builder and not sentinel URI builder to configure the SentinelURI correctly. Associate masterId with outermost RedisURI. Original pull request: #495.
mp911de
pushed a commit
that referenced
this pull request
Nov 12, 2019
…o Sentinel. We now expose two separate properties in RedisSentinelConfiguration to configure the data password individually from the sentinel password. Original pull request: #495.
mp911de
added a commit
that referenced
this pull request
Nov 12, 2019
Remove data node password reuse for sentinel as we favor explicit configuration over implicit. Use RedisURI builder and not sentinel URI builder to configure the SentinelURI correctly. Associate masterId with outermost RedisURI. Original pull request: #495.
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we now offer a dedicated property for authenticating with Sentinel.
However providing authentication for Sentinel only works using Lettuce until redis/jedis#1943 is resolved.