Add OAuth2-Client ConnectionDetails and Keycloak Docker-Compose support #39391
+825
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36777
This PR includes:
Registration
+Provider
Open Questions:
Since the
Registration
has a lot fields that cant simply be extracted from any Keycloak env. variables, I added Docker service labels to set e.g. thescope
of the client, or the client secret. Is this the best way to handle this?I also thought about not ignoring the
PropertiesOAuth2ClientConnectionDetails
if the Docker-Compose support already created anOAuth2ClientConnectionDetails
Bean, but rather merge them together, so that the registration-id, provider are extracted from the Keycloak env. variables and the other settings (scope
,client-secret
, etc.) could be set in theapplication.properties
. I am not sure which to prefer.When the open questions are answered, I would also add the TestContainer-Support for Keycloak.