Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Spring Security Reference Guide in Accessing the H2 Console in a Secured Application #30349

Conversation

hpoettker
Copy link
Contributor

Thanks for merging #29932! Configuring Spring Security can be a challenge for beginners, and I think the added paragraph will be helpful.

I checked the deployed snapshot versions of the documentation. Unfortunately, only the 2.5.x version has working links to the Spring Security reference guide. For Spring Boot 2.6.x, they need to be adjusted against the new structure of the Spring Security documentation that came with 5.6: https://docs.spring.io/spring-boot/docs/2.6.5-SNAPSHOT/reference/htmlsingle/#data.sql.h2-web-console.spring-security

This PR is only half the solution, as {spring-security-docs} resolves to https://docs.spring.io/spring-security/reference/5.6.2. But all links with this particular version do not work while they do e.g. for 5.6.1 or 5.6. It seem to be the same problem as in #28407 but the fix for that has been basically reverted for #28618. As I don't know, what the best approach for this problem is, the PR doesn't address this.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2022
@wilkinsona
Copy link
Member

Thanks, @hpoettker. The docs should be available at https://docs.spring.io/spring-security/reference/5.6.2. I've asked the Security team to take a look.

@wilkinsona wilkinsona added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Mar 21, 2022
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team labels Mar 22, 2022
@snicoll snicoll added this to the 2.6.5 milestone Mar 22, 2022
@wilkinsona
Copy link
Member

wilkinsona commented Mar 23, 2022

Thanks to @eleftherias, the 5.6.2 docs are now in place so we can merge this as-is I believe.

@wilkinsona wilkinsona added type: documentation A documentation update and removed type: task A general task labels Mar 23, 2022
@wilkinsona wilkinsona self-assigned this Mar 23, 2022
@wilkinsona wilkinsona changed the title Fix links to Spring Security Reference Guide Fix links to Spring Security Reference Guide in Accessing the H2 Console in a Secured Application Mar 23, 2022
wilkinsona pushed a commit that referenced this pull request Mar 23, 2022
@wilkinsona
Copy link
Member

Thanks very much, @hpoettker.

@hpoettker hpoettker deleted the fix-links-to-spring-security branch March 23, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants