Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary allocations in Prometheus scraping endpoint #30085

Closed
wants to merge 2 commits into from
Closed

Unnecessary allocations in Prometheus scraping endpoint #30085

wants to merge 2 commits into from

Commits on Mar 7, 2022

  1. Performance tweak for Prometheus scraping endpoint. 

    Reduce the number of times capacity growth is needed inside the StringWriter. A typical default SpringBoot Prometheus page has more than 11k characters. Best performance results when no capacity growth is needed at all, so base it on previous metrics page size plus some room for possible extra metric info.
    @stokpop
    stokpop committed Mar 7, 2022
    Copy the full SHA
    ea715b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Performance tweak for Prometheus scraping endpoint: do not use the in… 

    …itial 12k but the StringWriter default size.
    @stokpop
    stokpop committed Mar 8, 2022
    Copy the full SHA
    6a43f2f View commit details
    Browse the repository at this point in the history