Exception inclusion cannot be disabled when sub-classing DefaultErrorAttributes and using its deprecated constructor #22750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lopfest Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Lopfest Thank you for signing the Contributor License Agreement! |
scottfrederick
added
type: bug
scottfrederick
pushed a commit
to scottfrederick/spring-boot
that referenced
this pull request
Aug 17, 2020
This commit fixes a problem with the handling of the includeException field in DefaultErrorAttributes. See spring-projectsgh-22750
scottfrederick
added a commit
to scottfrederick/spring-boot
that referenced
this pull request
Aug 17, 2020
|
@Lopfest Thank you for your first contribution to Spring Boot. Your change has been merged along with another commit that adds tests to verify the broken behavior before your change and confirm the fix after your change. The change was applied to the |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when you extend DefaultErrorAttributes and create new object with deprecated constructor, there is no way to disable exception attribute in error output even if you specify
server.error.include-exception=falsein application.properties.If
this.includeExceptionisfalse, it should not be included in ErrorAttributeOptions.With this fix it should work properly, meaning if
this.includeExceptionisnullorfalse, exception is not included.Since: 2.3.0
Related commit: 158933c