Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Configuration for Cassandra does not back off if a custom ReactiveSessionFactory is defined #21769

Conversation

tszmytka
Copy link
Contributor

@tszmytka tszmytka commented Jun 8, 2020

…ions to create it on their own.

This addresses #21741 by annotating reactiveCassandraSessionFactory bean with @ConditionalOnMissingBean

@pivotal-issuemaster
Copy link

@tszmytka Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 8, 2020
@pivotal-issuemaster
Copy link

@tszmytka Thank you for signing the Contributor License Agreement!

@snicoll snicoll self-assigned this Jun 10, 2020
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2020
@snicoll snicoll added this to the 2.3.x milestone Jun 10, 2020
@snicoll snicoll changed the title Make reactiveCassandraSessionFactory bean conditional. Allow applicat… Auto-Configuration for Cassandra does not back off if a custom ReactiveSessionFactory is defined Jun 10, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.1 Jun 10, 2020
snicoll pushed a commit that referenced this pull request Jun 10, 2020
This commit makes sure that CassandraReactiveDataAutoConfiguration does
not create a reactiveCassandraSessionFactory bean if the user has
provided their own.

See gh-21769
@snicoll snicoll closed this in 6c926f7 Jun 10, 2020
@snicoll
Copy link
Member

snicoll commented Jun 10, 2020

@tszmytka thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants