Polish duration support javadoc #21579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These throw IllegalArgumentException, not IllegalStateException.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR but those are two completely unrelated changes unless I am missing something. We're still discussing whether we want to move that one package private so we can't review the second commit. Can you please drop 69b543d and we can merge this one as a Javadoc polish. |
snicoll
added
the
status: waiting-for-feedback
|
Ah, didn't see that issue. |
spring-projects-issues
added
status: feedback-provided
|
If you revert the change of visibility we can consider that as part of a javadoc polish indeed. |
snicoll
added
type: documentation
snicoll
pushed a commit
that referenced
this pull request
May 26, 2020
snicoll
added a commit
that referenced
this pull request
May 26, 2020
|
Thanks for the follow-up @OrangeDog and for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change if someone was using the Period converters externally, but they should've been package-final from the start.