Fix duplicate slashes in URL links #21108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: documentation
snicoll
changed the title
jkatada
force-pushed
the
fix-duplicate-slashes-in-URL-links
branch
from
8f0d626
to
a87a904
Compare
snicoll
requested changes
May 4, 2020
There was a problem hiding this comment.
Thank you very much for raising your first PR @jkatada
Rather that removing the / after the variable, I'd like us to add it (if necessary) and remove it from the variable. We can see that's what we've done for code there and it reads more naturally to me.
Would you have time to rework the PR in that direction?
| @@ -91,7 +91,7 @@ private void writeTable(AutoConfiguration autoConfigurationClasses) throws IOExc | |||
| writer.println(); | |||
| writer.printf("| {spring-boot-code}/spring-boot-project/%s/src/main/java/%s.java[`%s`]%n", | |||
| autoConfigurationClasses.module, autoConfigurationClass.path, autoConfigurationClass.name); | |||
| writer.printf("| {spring-boot-api}/%s.html[javadoc]%n", autoConfigurationClass.path); | |||
| writer.printf("| {spring-boot-api}%s.html[javadoc]%n", autoConfigurationClass.path); | |||
There was a problem hiding this comment.
I think we should rather stick to a / after the variable rather than no slash. This means that {spring-boot-api} would not end with a slash.
snicoll
added
the
status: waiting-for-feedback
jkatada
force-pushed
the
fix-duplicate-slashes-in-URL-links
branch
from
a87a904
to
3f8c56e
Compare
|
@snicoll Thanks for the feedback. I've updated the PR. Please review. |
spring-projects-issues
added
status: feedback-provided
snicoll
pushed a commit
that referenced
this pull request
May 5, 2020
|
@jkatada thanks for the follow-up and for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix links which have duplicate slashes in reference documentation.
link examples