Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MustacheEnvironmentCollector to not ignore native fetcher #21060

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
.#*
.*.md.html
.DS_Store
.attach_pid*
.classpath
.factorypath
.gradle
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import com.samskivert.mustache.DefaultCollector;
import com.samskivert.mustache.Mustache.Collector;
import com.samskivert.mustache.Mustache.VariableFetcher;
import com.samskivert.mustache.Template;

import org.springframework.context.EnvironmentAware;
import org.springframework.core.env.ConfigurableEnvironment;
Expand All @@ -35,8 +36,6 @@ public class MustacheEnvironmentCollector extends DefaultCollector implements En

private ConfigurableEnvironment environment;

private final VariableFetcher propertyFetcher = new PropertyVariableFetcher();

@Override
public void setEnvironment(Environment environment) {
this.environment = (ConfigurableEnvironment) environment;
Expand All @@ -46,19 +45,45 @@ public void setEnvironment(Environment environment) {
public VariableFetcher createFetcher(Object ctx, String name) {
VariableFetcher fetcher = super.createFetcher(ctx, name);
if (fetcher != null) {
return fetcher;
return new PropertyVariableFetcher(fetcher);
}
if (this.environment.containsProperty(name)) {
return this.propertyFetcher;
return new PropertyVariableFetcher();
}
return null;
}

private class PropertyVariableFetcher implements VariableFetcher {

private final VariableFetcher nativeFetcher;

PropertyVariableFetcher() {
this.nativeFetcher = null;
}

PropertyVariableFetcher(VariableFetcher nativeFetcher) {
this.nativeFetcher = nativeFetcher;
}

@Override
public Object get(Object ctx, String name) {
return MustacheEnvironmentCollector.this.environment.getProperty(name);
Object result;
if (this.nativeFetcher != null) {
try {
result = this.nativeFetcher.get(ctx, name);
if (result != null && result != Template.NO_FETCHER_FOUND) {
return result;
}
}
catch (Exception ex) {
// fall through
}
}
result = MustacheEnvironmentCollector.this.environment.getProperty(name);
if (result == null) {
return Template.NO_FETCHER_FOUND;
}
return result;
}

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* @author Dave Syer
*/
@DirtiesContext
@SpringBootTest(webEnvironment = WebEnvironment.NONE, properties = { "env.FOO=There", "foo=World" })
@SpringBootTest(webEnvironment = WebEnvironment.NONE, properties = { "env.FOO=There", "foo=World", "bar.name=Bar" })
class MustacheStandaloneIntegrationTests {

@Autowired
Expand All @@ -60,15 +60,51 @@ void environmentCollectorCompoundKeyStandard() {
.isEqualTo("Hello: There");
}

@Test
void environmentCollectorCompoundKeyStandardMap() {
assertThat(this.compiler.standardsMode(true).compile("Hello: {{env.foo}}")
.execute(Collections.singletonMap("world", "World"))).isEqualTo("Hello: There");
}

@Test
void environmentCollectorCompoundKeyWithBean() {
assertThat(this.compiler.compile("Hello: {{foo.name}}")
.execute(Collections.singletonMap("foo", new Foo()))).isEqualTo("Hello: Foo");
}

@Test
void environmentCollectorCompoundKeyWithBeanPrefersEnvironment() {
assertThat(this.compiler.compile("Hello: {{bar.name}}")
.execute(Collections.singletonMap("bar", new Foo()))).isEqualTo("Hello: Bar");
}

@Test
void environmentCollectorSimpleKey() {
assertThat(this.compiler.compile("Hello: {{foo}}").execute(new Object())).isEqualTo("Hello: World");
}

@Test
void environmentCollectorSimpleKeyMap() {
assertThat(this.compiler.compile("Hello: {{foo}}").execute(Collections.singletonMap("world", "Foo")))
.isEqualTo("Hello: World");
}

@Configuration(proxyBeanMethods = false)
@Import({ MustacheAutoConfiguration.class, PropertyPlaceholderAutoConfiguration.class })
static class Application {

}

static class Foo {
private String name = "Foo";

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}
}

}