Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@SpringBootTest not picking @Named classes with a non-public constructor #20929

Closed
wants to merge 1 commit into from
Closed

@SpringBootTest not picking @Named classes with a non-public constructor #20929

wants to merge 1 commit into from

Conversation

encircled
Copy link
Contributor

@encircled encircled commented Apr 13, 2020 •
edited by snicoll

Fixes #20930

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 13, 2020
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Apr 13, 2020
@philwebb philwebb self-assigned this Apr 15, 2020
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2020
@philwebb philwebb added this to the 2.3.x milestone Apr 15, 2020
@snicoll snicoll mentioned this pull request Apr 15, 2020
Closed
@philwebb philwebb changed the title Fix @SpringBootTest not picking @Named classes with a non-public cons… @SpringBootTest not picking @Named classes with a non-public constructor Jun 6, 2020
@philwebb philwebb mentioned this pull request Jun 6, 2020
Closed
philwebb pushed a commit that referenced this pull request Jun 6, 2020
@encircled @philwebb
Allow beans without public constructors to load
d8d8f9c 
Allow `BeanDefinitionLoader` to load classes that don't have public
constructors. The constraint was first introduced in d82c508 to
solve an issue with anonymous Groovy classes but causes particular
problems with `@SpringBootTest`.

See gh-20929
philwebb added a commit that referenced this pull request Jun 6, 2020
@philwebb
Polish 'Allow beans without public constructors to load'
c11abf4 
See gh-20929
@philwebb philwebb closed this in 6e02049 Jun 6, 2020
@philwebb philwebb modified the milestones: 2.3.x, 2.3.1 Jun 6, 2020
@philwebb
Copy link
Member

philwebb commented Jun 6, 2020

Thanks very much for your contribution @encircled. This has now been merged into 2.3.x and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
for: merge-with-amendments Needs some changes when we merge type: bug A general bug
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

@SpringBootTest not picking classes annotated by @Named with a constructor
4 participants
@encircled @philwebb @snicoll @spring-projects-issues