Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend configuring compileJava's inputs to include processResources' output when generating configuration metadata #20323

Closed
wants to merge 1 commit into from
Closed

Recommend configuring compileJava's inputs to include processResources' output when generating configuration metadata #20323

wants to merge 1 commit into from

Commits on Feb 26, 2020

  1. Fix configuration-processor documentation for Gradle 

    `compileJava.dependsOn(processResources)` is not enough to ensure the correct behavior.

Using `dependsOn` only affects the execution order (`processResources` before `compileJava`) but not the up-to-date check of `compileJava`: After modifying `META-INF/additional-spring-configuration-metadata.json` the `processResouces` task will considered out-of-date and will be re-executed, but after that `compileJava` will still be considered up-to-date which causes the changes not to be merged into `META-INF/spring-configuration-metadata.json`

With this change the up-do-date check of `compileJava` is affected, too. Therefore it will correctly re-execute the configuration-processor when `META-INF/additional-spring-configuration-metadata.json` was changed.
    @larsgrefer
    larsgrefer committed Feb 26, 2020
    Configuration menu
    Copy the full SHA
    e7c285b View commit details
    Browse the repository at this point in the history