Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Spring Integration Graph documentation #19992

Closed

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR fixes another tiny link problem in the docs.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 31, 2020
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dreis2211. I'd like to fix this one a bit differently and wonder what you think of that proposal.

@@ -20,7 +20,7 @@ include::{snippets}/integrationgraph/graph/http-response.adoc[]
[[integrationgraph-retrieving-response-structure]]
=== Response Structure
The response contains all Spring Integration components used within the application, as well as the links between them.
More information about the structure can be found in the https://docs.spring.io/spring-integration/reference/html/#integration-graph[reference documentation].
More information about the structure can be found in the https://docs.spring.io/spring-integration/reference/html/index-single.html#integration-graph[reference documentation].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a {spring-integration-docs} we could use to point to the Spring Integration release that Spring Boot uses. I'd rather update the URL to use that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - I've just focussed on the fragment that didn't work. Feel free to decline or let me know if I should adjust the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have time to adapt, more than happy to review an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just looked into it. {spring-integration-docs} isn't available here as we're in the actuator autoconfigure docs and not in the normal ones. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what happens when I review something on github. It would probably makes sense to add the version of Spring Integration there if we need it.

There's no tasks.withType(org.asciidoctor.gradle.jvm.AbstractAsciidoctorTask) { but I suppose adding that should work fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed an updated version. Let me know if that was the solution you imagined.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Feb 1, 2020
@snicoll snicoll changed the title Fix link to Integration Graph docs Fix link to Spring Integration Graph documentation Feb 3, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Feb 3, 2020
@snicoll snicoll modified the milestones: 2.2.5, 2.3.0.M2 Feb 3, 2020
snicoll pushed a commit that referenced this pull request Feb 3, 2020
@snicoll snicoll closed this in cde92f0 Feb 3, 2020
@snicoll
Copy link
Member

snicoll commented Feb 3, 2020

Thanks @dreis2211. The change in 2.2.x was completely different so I did that in #20023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants