Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ServerHttpResponse.getRawStatusCode() in WebFluxTags #19987

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jan 30, 2020

This PR changes to use ServerHttpResponse.getRawStatusCode() in WebFluxTags.

This PR also changes Spring Framework version to 5.2.4.BUILD-SNAPSHOT for the necessary upstream change.

See #19367 (comment)

This commit also changes Spring Framework version to 5.2.4.BUILD-SNAPSHOT for the necessary upstream change.

See spring-projects#19367 (comment)
@dreis2211
Copy link
Contributor

You were a minute faster than me 😆

@wilkinsona wilkinsona added this to the 2.2.x milestone Jan 30, 2020
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 30, 2020
@wilkinsona
Copy link
Member

2.3.0.M2 is going to ship before Framework 5.2.4 (it'll stick on 5.2.3). Let's merge this into 2.2.x after 2.3.0.M2 has shipped. It can then be merged forwards into master at the same time.

@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Jan 30, 2020
@spencergibb
Copy link
Member

Since boot 2.2.x is on framework 5.2.3 will boot 2.2.x get framework 5.2.4? spring cloud gateway could make a similar change in Hoxton based on boot 2.2.x

@wilkinsona
Copy link
Member

Yep. 2.2.5 will ship on top of Framework 5.2.4.

@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label Mar 4, 2020
@snicoll snicoll modified the milestones: 2.2.x, 2.2.6 Mar 4, 2020
@snicoll
Copy link
Member

snicoll commented Mar 4, 2020

We've missed this one, sorry about that. It'll be available in 2.2.6 rather.

@snicoll snicoll closed this in 743671f Mar 4, 2020
@snicoll snicoll self-assigned this Mar 4, 2020
@izeye izeye deleted the web-flux-tags branch March 4, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants