Add JMX note for Kafka consumer metrics #19446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Dec 24, 2019
| @@ -1644,7 +1644,7 @@ Spring Boot registers the following core metrics when applicable: | |||
| ** Number of classes loaded/unloaded | |||
| * CPU metrics | |||
| * File descriptor metrics | |||
| * Kafka consumer metrics | |||
| * Kafka consumer metrics (`spring.jmx.enabled` must be set to `true`) | |||
There was a problem hiding this comment.
This is a good idea. I'd rather change the note to something like "JMX support should be enabled" or something like that with a link to the section that explains how to do it rather than the reference to the property.
There was a problem hiding this comment.
@snicoll Thanks for the feedback! I changed it as suggested.
There was a problem hiding this comment.
Thanks for the quick feedback. I meant that the text on "JMX support" should be a link to the relevant section. Have you missed it or do you disagree with that approach?
There was a problem hiding this comment.
@snicoll Sorry. I overlooked your comment. I changed it again. Please let me know if it isn't what you meant.
izeye
force-pushed
the
kafka-consumer-metrics
branch
from
6208617
to
f109bdd
Compare
izeye
force-pushed
the
kafka-consumer-metrics
branch
from
f109bdd
to
5c5b4f3
Compare
snicoll
added
type: documentation
snicoll
pushed a commit
that referenced
this pull request
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #19348, it seems to be good to add a JMX note for Kafka consumer metrics similar to Tomcat metrics.