Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visibility for IdentityProvider property #19195

Closed
wants to merge 2 commits into from

Conversation

sbattistin
Copy link

Update visibility for IdentityProvider property inside Registration class for Saml2 relying party properties

Updated visibility for IdentityProvider property inside Registration class for Saml2 relying party properties
…-property-visibility

Updated visibility for IdentityProvider property
@pivotal-issuemaster
Copy link

@sbattistin Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@wilkinsona
Copy link
Member

Thanks for the PR. As noted in the documentation, @ConfigurationProperties classes available in Spring Boot are for internal use only. The properties that map to the class, which are configured via properties files, YAML files, environment variables etc., are public API but the content of the class itself is not meant to be used directly.

Given that, I don't think we necessarily want to make the method public if it does not need to be. There's a mixture of public and package-private methods at the moment. Let's use #19194 to address that. Thanks anyway.

@wilkinsona wilkinsona closed this Nov 29, 2019
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2019
@pivotal-issuemaster
Copy link

@sbattistin Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants