Spring Boot CLI is unable to always capture ctrl-c #17976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the Spring Boot CLI ran the Java command line for an application it did a straight invocation which suppressed propagation of signals to the JVM in certain circumstances (e.g within Docker containers). This change prepends the command with exec which causes the Java process to replace the script process in a shell ensuring that signals are propagated to the Java process without suppression. Signed-off-by: Ben Hale <bhale@pivotal.io>
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
for: team-attention
philwebb
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Aug 29, 2019
Previously, when the Spring Boot CLI ran the Java command line for an application it did a straight invocation which suppressed propagation of signals to the JVM in certain circumstances (e.g within Docker containers). This change prepends the command with exec which causes the Java process to replace the script process in a shell ensuring that signals are propagated to the Java process without suppression. See gh-17976 Signed-off-by: Ben Hale <bhale@pivotal.io>
|
Thanks very much, @nebhale. The proposed change has been merged into 2.1.x and forwards into master. |
pull bot
pushed a commit
to scope-demo/spring-boot
that referenced
this pull request
Aug 29, 2019
Previously, when the Spring Boot CLI ran the Java command line for an application it did a straight invocation which suppressed propagation of signals to the JVM in certain circumstances (e.g within Docker containers). This change prepends the command with exec which causes the Java process to replace the script process in a shell ensuring that signals are propagated to the Java process without suppression. See spring-projectsgh-17976 Signed-off-by: Ben Hale <bhale@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the Spring Boot CLI ran the Java command line for an application it did a straight invocation which suppressed propagation of signals to the JVM in certain circumstances (e.g. within Docker containers).
This change prepends the command with
execwhich causes the Java process to replace the script process in a shell ensuring that signals are propagated to the Java process without suppression.