Use alwaysApplyingWhenNonNull PropertyMapper to set the values in the LdapContextSource #17861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
filiphr
added a commit
to flowable/flowable-engine
that referenced
this pull request
Aug 14, 2019
…m tests Before 2.1.0 the LdapHealthIndicator was not created due to the missing LdapOperations. However since 2.1 the LdapOperations bean creation was moved into the LdapAutoConfiguration (see spring-projects/spring-boot#13136) which lead to the LdapHealthIndicator being created and thus the FlowableIdmApplicationSecurityTest was failing due to the ldap user and password being null. See spring-projects/spring-boot#17861 for the problem in Spring Boot
… LdapContextSource The userDn and password in LdapContextSource are not nullable. The default values for userDn and password in LdapProperties are null. When the values are set to null there will eventually be a NullPointerException during AbstractContextSource#setupAuthenticatedEnvironment since HashTable doesn't allow null for values
filiphr
force-pushed
the
use-property-mapper-for-ldap-context-source
branch
from
6d933c5
to
c404120
Compare
|
Thanks for spotting this one, it looks like a legitimate bug on our side but also something that could be improved in spring-ldap. I've raised spring-projects/spring-ldap#538 to see if they can make things more robust. |
philwebb
added
type: bug
|
Thanks for raising the issue in spring-ldap. Once I started writing the fix for Spring Boot I also realized that making it more robust in spring-ldap might be the best thing. Something like that is already done in Thanks for taking the fix into consideration. |
snicoll
pushed a commit
that referenced
this pull request
Aug 17, 2019
The userDn and password in LdapContextSource are not nullable. The default values for userDn and password in LdapProperties are null. When the values are set to null there will eventually be a NullPointerException during AbstractContextSource#setupAuthenticatedEnvironment since HashTable doesn't allow null for values. See gh-17861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
userDnandpasswordinLdapContextSourceare not nullable.The default values for
userDnandpasswordinLdapPropertiesare `null.When the values are set to null there will eventually be a
NullPointerExceptionduring
AbstractContextSource#setupAuthenticatedEnvironmentsinceHashTabledoesn't allow null for valuesI am not sure whether this should be fixed here in spring-boot, or perhaps directly within
LdapContextSource.