Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong annotation lookup with proxied endpoints #17807

Closed

Conversation

jebeaudet
Copy link
Contributor

@jebeaudet jebeaudet commented Aug 7, 2019

Fixes #17804, sorry I didn't originally mean to create a PR immediately.

…horize annotation causing a NPE because of the CGLIB proxy created. Fixes spring-projectsgh-17804.
@snicoll
Copy link
Member

snicoll commented Aug 8, 2019

Thanks for the PR @jebeaudet. It's an oversight on our end as we should have used find semantic vs. get semantic. There are two other cases where we've done the same that I'll fix as a polish of this PR.

@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 8, 2019
@snicoll snicoll self-assigned this Aug 8, 2019
@snicoll snicoll added this to the 2.1.8 milestone Aug 8, 2019
@snicoll snicoll changed the title Added support for endpoint extension that are using @PreAuthorize Wrong annotation lookup with proxied endpoints Aug 8, 2019
snicoll pushed a commit that referenced this pull request Aug 8, 2019
@snicoll snicoll closed this in b31c336 Aug 8, 2019
@snicoll
Copy link
Member

snicoll commented Aug 8, 2019

@jebeaudet Thank you for making your first contribution to Spring Boot. Turns out master was broken as well in a different way as we've rewritten annotation lookup and missed another case. I'll flag this one for team attention as the two other use of getMergedAnnotationAttributes doesn't sound wrong to me but I'd like to double check with the team.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Aug 8, 2019
@jebeaudet jebeaudet deleted the fix/ProxiedEndpoint branch August 8, 2019 12:57
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants