Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quartz may attempt to use the DataSource before migrations have been run #17539

Closed
wants to merge 1 commit into from
Closed

Quartz may attempt to use the DataSource before migrations have been run #17539

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Jul 16, 2019

see gh-17528

@nosan nosan changed the title Ensure that that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Ensure that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Jul 16, 2019
@nosan nosan force-pushed the gh-17528 branch 2 times, most recently from 1dcbbff to b5a68f5 Compare July 16, 2019 19:44
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 16, 2019
@wilkinsona wilkinsona mentioned this pull request Jul 17, 2019
Closed
@wilkinsona wilkinsona changed the title Ensure that SchedulerFactoryBean and Scheduler beans depend on the Flyway and Liquibase. Quartz may attempt to use the DataSource before migrations have been run Jul 17, 2019
@wilkinsona wilkinsona added the type: bug A general bug label Jul 17, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Jul 17, 2019
@philwebb philwebb mentioned this pull request Jul 24, 2019
Closed
@philwebb philwebb removed the status: waiting-for-triage An issue we've not yet triaged label Jul 24, 2019
@philwebb philwebb self-assigned this Sep 1, 2019
@philwebb philwebb mentioned this pull request Sep 1, 2019
Closed
philwebb pushed a commit that referenced this pull request Sep 1, 2019
@nosan @philwebb
Ensure Flyway/Liquibase runs before Quartz
7e5bd1f 
Add post processors to ensure that SchedulerFactoryBean and Scheduler
beans depend on the Flyway and Liquibase beans.

See gh-17539
philwebb added a commit that referenced this pull request Sep 1, 2019
@philwebb
Polish "Ensure Flyway/Liquibase runs before Quartz"
75a1a24 
See gh-17539
@philwebb philwebb closed this in 0cfcbcb Sep 1, 2019
@philwebb
Copy link
Member

philwebb commented Sep 1, 2019

Thanks yet again @nosan! This has now been merged into 2.1 and forward-ported to 2.2. I changed things slightly in 75a1a24 so @Bean methods are used in favor of multiple @Configuration classes.

@philwebb philwebb modified the milestones: 2.1.x, 2.1.8 Sep 1, 2019
philwebb added a commit that referenced this pull request Sep 2, 2019
@philwebb
Reduce bean method visibility
2be3027 
See gh-17539
@wilkinsona wilkinsona mentioned this pull request Sep 3, 2019
Closed
@nosan
Copy link
Contributor Author

nosan commented Sep 3, 2019

Thank you very much, @philwebb

Just to make sure, I see that @ConditionalOnClass annotations have been removed. Did you really want to remove them or it was done accidentally?

@nosan nosan deleted the gh-17528 branch September 3, 2019 17:28
@philwebb
Copy link
Member

philwebb commented Sep 3, 2019

Hi @nosan, That was intentional and @ConditionalOnBean should deal with any ClassNotFoundException.

@anderius anderius mentioned this pull request Sep 6, 2019
Closed
@eye-dee
Copy link

eye-dee commented Jun 19, 2020 •
edited

Hello @philwebb

I'm facing this issue right now. Could you take a look please?

spring boot version: 2.3.1.RELEASE

@wilkinsona
Copy link
Member

@SausageRoll AFAIK, this problem's been fixed since 2.1.8 and shouldn't occur with 2.3.1. If you are seeing it with 2.3.1, please open a new issue and provide a minimal sample that reproduces the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nosan @philwebb @eye-dee @wilkinsona @spring-projects-issues