SolrHealthIndicator reports down when baseUrl references a core instead of the root context #16477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schuch Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@schuch Thank you for signing the Contributor License Agreement! |
schuch
changed the title
… returns a 404 which might indicate the SolrClient's baseUrl points to a particular core
reformatted code
snicoll
added
type: bug
philwebb
changed the title
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Sep 3, 2019
Update `SolrHealthIndicator` to fallback to a basic ping operation if the `baseUrl` references a particular core rather than the root context. Prior to this commit, if the Solr `baseUrl` pointed to a particular core then the health indicator would incorrectly report `DOWN`. See gh-16477
philwebb
added a commit
that referenced
this pull request
Sep 3, 2019
schuch
deleted the
gh-16256-solrhealthindicator-for-baseurls-with-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added heuristic approach to fallback to SolrPing if CoreAdmin request returns a 404 which might indicate the SolrClient's baseUrl points to a particular core
Fixes gh-16256