Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThymeleafAutoConfiguration fails if thymeleaf-spring5 is not present #16341

Conversation

koziolk
Copy link
Contributor

@koziolk koziolk commented Mar 27, 2019

This commit adds an extra check for the presence of thymeleaf-spring5
library on the classpath. Since now ThymeleafAutoConfiguration is
considered only if both thymeleaf-spring5 and thymeleaf jars are present.

gh-16079

This commit adds an extra check for the presence of thymeleaf-spring5
library on the classpath. Since now ThymeleafAutoConfiguration is
considered only if both thymeleaf-spring5 and thymeleaf jars are present.

spring-projectsgh-16079
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 27, 2019
@koziolk
Copy link
Contributor Author

koziolk commented Mar 28, 2019

The current code base from master does not build.
When one run ./mvnw clean install it fails when executing Spring Boot AutoConfigure tests.

You can spot this build failure in the latest builds:

I was able to reproduce it locally with the following configuration:

JVM/Maven:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
Maven home: /Users/koziolk/.m2/wrapper/dists/apache-maven-3.5.4-bin/4lcg54ki11c6mp435njk296gm5/apache-maven-3.5.4
Java version: 1.8.0_202, vendor: AdoptOpenJdk, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
Default locale: en_PL, platform encoding: UTF-8
OS name: "mac os x", version: "10.14.4", arch: "x86_64", family: "mac"

Git revision
3e3353e0e977d2e229e2490a2e6f292b9fa50894

Let me know if it's a known case or if I should raise an issue for it.

@snicoll
Copy link
Member

snicoll commented Mar 28, 2019

Thank you. As you’ve seen yourself CI has been failing, probably due to a change in a snapshot dependency. We are aware of it and will work on a fix.

@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 28, 2019
@snicoll snicoll added this to the 2.1.x milestone Mar 28, 2019
@snicoll snicoll self-assigned this Mar 28, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Mar 28, 2019
snicoll added a commit that referenced this pull request Mar 28, 2019
* pr/16341:
  Add missing class condition on thymeleaf-spring5
@snicoll snicoll closed this in 17c0214 Mar 28, 2019
@snicoll
Copy link
Member

snicoll commented Mar 28, 2019

@koziolk thank you for making your first contribution to Spring Boot. Your work has been merged in 2.1.x and master.

@snicoll
Copy link
Member

snicoll commented Mar 28, 2019

Also, @mbhave reminded me we should have requested a test for this. I had to first rewrite to use the new test utility in 29b1b38 and I've added a test in 6c3d64a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants