Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management for micrometer-registry-stackdriver is missing #16178

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Mar 8, 2019

This PR adds dependency management for micrometer-registry-stackdriver.

@wilkinsona
Copy link
Member

Thanks, @izeye. Does this mean we're missing some auto-configuration as well? On the dependency management side of it, I'd much rather fix this by being able to import a Micrometer bom. @jkschneider, is there any chance of micrometer-metrics/micrometer#469 being tackled soon?

@izeye
Copy link
Contributor Author

izeye commented Mar 9, 2019

@wilkinsona Thanks for the feedback! I'm not sure about auto-configuration on it as it's marked as incubating.

@wilkinsona
Copy link
Member

Thanks, @izeye. Let's hold off on any auto-configuration for now then.

@wilkinsona wilkinsona changed the title Add dependency management for micrometer-registry-stackdriver Dependency management for micrometer-registry-stackdriver is missing Mar 9, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Mar 9, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 9, 2019
@snicoll snicoll self-assigned this Mar 12, 2019
snicoll added a commit that referenced this pull request Mar 12, 2019
* pr/16178:
  Add dependency management for micrometer-registry-stackdriver
@snicoll snicoll modified the milestones: 2.1.x, 2.1.4 Mar 12, 2019
@snicoll snicoll closed this in 00bda4d Mar 12, 2019
@izeye izeye deleted the stackdriver branch March 12, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants